Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] add e2e on device training test #1323

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

pilkicTT
Copy link
Contributor

Adding MNIST training test which runs everything on device, i.e. fwd/bwd of the model and loss function, as well as the optimizer.

Additionally, modified the test_lora test to use optimizer on device.

Copy link

TestsPassed ☑️Skipped ⚠️Failed ❌️
TT-Forge-FE Tests612 ran479 passed132 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_dla.test_dla_pytorch[dla34]❌ failure

Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests612 ran480 passed132 skipped0 failed
TestResult
No test annotations available

Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran539 passed131 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran539 passed131 skipped0 failed
TestResult
No test annotations available

Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests612 ran480 passed132 skipped0 failed
TestResult
No test annotations available

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment.

Copy link
Contributor

@pglusacTT pglusacTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one question

Copy link
Contributor

@pmarkovicTT pmarkovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Adding MNIST training test which runs everything on device, i.e.
fwd/bwd of the model and loss function, as well as the optimizer.

Additionally, modified the `test_lora` test to use optimizer on device.
@pilkicTT pilkicTT force-pushed the pilkic/test-train-e2e branch from 1775e3c to d36196f Compare February 27, 2025 11:45
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests617 ran482 passed135 skipped0 failed
TestResult
No test annotations available

Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests675 ran541 passed134 skipped0 failed
TestResult
No test annotations available

Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests617 ran482 passed135 skipped0 failed
TestResult
No test annotations available

Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests675 ran541 passed134 skipped0 failed
TestResult
No test annotations available

@pilkicTT pilkicTT merged commit cbcd356 into main Feb 27, 2025
10 checks passed
@pilkicTT pilkicTT deleted the pilkic/test-train-e2e branch February 27, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants